Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate basic authentication #188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integrate basic authentication #188

wants to merge 2 commits into from

Conversation

radutanasa
Copy link

Used play-basic-authentication-filter from kaliber

@@ -39,6 +40,8 @@ class ApplicationComponents(context: Context) extends BuiltInComponentsFromConte
private[this] lazy val assetsC = new controllers.Assets(httpErrorHandler)
private[this] lazy val webJarsAssetsC = new controllers.WebJarAssets(httpErrorHandler, context.initialConfiguration, context.environment)

override lazy val httpFilters = Seq(BasicAuthenticationFilter(context.initialConfiguration))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you can add configuration to enable it. Not everyone may want to enable it.

@radutanasa
Copy link
Author

OK, sounds good. I'll look into it.

@MichaelScofield
Copy link

hi, how is this merge pr going? it's nice to have authentication :)

@radutanasa
Copy link
Author

There's been a request to make this configurable, but haven't had the time
to do it. Hopefully I'll be able to address it soon!

On Tue, Feb 23, 2016 at 4:29 AM, Fucong.Luo [email protected]
wrote:

hi, how is this merge pr going? it's nice to have authentication :)


Reply to this email directly or view it on GitHub
#188 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants